Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use http_port extra variables instead of nginx ones #14204

Merged
merged 1 commit into from
Mar 6, 2017

Conversation

carbonin
Copy link
Member

@carbonin carbonin commented Mar 6, 2017

The http/https_port variables are used to set the nginx variables and are also used to inform tower what port to use to access their own REST api. We need to set these properly to run playbooks.

Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Will merge when green

The http/https_port variables are used to set the nginx variables
and are also used to inform tower what port to use to access
their own REST api. We need to set these properly to run playbooks.
@carbonin carbonin force-pushed the change_nginx_port_vars_to_http branch from 083c07c to 59a6b9e Compare March 6, 2017 20:25
@miq-bot
Copy link
Member

miq-bot commented Mar 6, 2017

Checked commit carbonin@59a6b9e with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks good. 🏆

@gtanzillo gtanzillo added this to the Sprint 56 Ending Mar 13, 2017 milestone Mar 6, 2017
@gtanzillo gtanzillo merged commit 61dd5d0 into ManageIQ:master Mar 6, 2017
@carbonin carbonin deleted the change_nginx_port_vars_to_http branch March 7, 2017 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants