add authentications sub collection to ConfigurationScriptPayload #14002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @abellotti |
abellotti
reviewed
Mar 1, 2017
| module Subcollections | ||
| module Authentications | ||
| def authentications_query_resource(object) | ||
| object.try(:authentications) || [] |
There was a problem hiding this comment.
would prefer:
object.respond_to?(:authentications) ? object.authentications : []
actual nil vs. [] is dealt differently in renderer. Thanks.
|
Checked commit jntullo@2f9b1fb with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Thanks @jntullo for the update. This LGTM!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an authentications subcollection to ConfigurationScriptPayload as needed to return authentications available on a playbook in the UI.
cc: @h-kataria
@miq-bot add_label enhancement, api
@miq-bot assign @abellotti