Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing reason constants #13919

Merged
merged 2 commits into from
Feb 14, 2017
Merged

Fix missing reason constants #13919

merged 2 commits into from
Feb 14, 2017

Commits on Feb 14, 2017

  1. Spec cleanup 

    * remove any_instance_of since we have an instance of a server!  🎉
* use lets, remove some ivars

https://bugzilla.redhat.com/show_bug.cgi?id=1395736
    @jrafanie
    jrafanie committed Feb 14, 2017
    Configuration menu
    Copy the full SHA
    6636853 View commit details
    Browse the repository at this point in the history

  2. Fix Reason NameError using constants included in MiqServer 

    Due to module inclusion spaghetti, it's easier and less confusing
to reference the Reason constants consistently in the MiqServer class,
which is the ultimate destination for all of these modules.

Fixes ManageIQ#13901 introduced in ManageIQ#13805

https://bugzilla.redhat.com/show_bug.cgi?id=1395736
    @jrafanie
    jrafanie committed Feb 14, 2017
    Configuration menu
    Copy the full SHA
    3ea55fa View commit details
    Browse the repository at this point in the history