Disks should be added as 'active' in RHV #13913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR ManageIQ#13318 introduced a new class to handle disk attachments. A disk should be added to RHV as 'active' since there is no method to modify it afterward. DiskAttachmentBuilder class will set the 'active' as the default status of the new disk, so any scenario which adds disks (vm reconfigure, automation request, provision request) will share the same behavior. https://bugzilla.redhat.com/show_bug.cgi?id=1422145
|
@miq-bot add_label blocker euwe/yes providers/rhevm |
|
@masayag Cannot apply the following label because they are not recognized: blocker euwe/yes providers/rhevm |
|
@miq-bot add_label blocker, euwe/yes. providers/rhevm |
|
@masayag Cannot apply the following label because they are not recognized: euwe/yes. providers/rhevm |
|
looks good to me. |
|
@miq-bot add_label euwe/yes, providers/rhevm |
|
Checked commit masayag@8fdeaad with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
👍 will merge when green |
simaishi
pushed a commit
that referenced
this pull request
Feb 14, 2017
…e_in_rhv Disks should be added as 'active' in RHV (cherry picked from commit a094a95) https://bugzilla.redhat.com/show_bug.cgi?id=1422178
|
Euwe backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #13318 introduced a new
class to handle disk attachments. A disk should be added to RHV as
'active' since there is no method to modify it afterward.
DiskAttachmentBuilder class will set the 'active' as the default
status of the new disk, so any scenario which adds disks (vm
reconfigure, automation request, provision request) will share the same
behavior.
https://bugzilla.redhat.com/show_bug.cgi?id=1422145