Add multiple_value option to expose_eligible_resources. #13853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lfu Please address the rubocop issue. Otherwise, this is looking really good. |
lfu
force-pushed
the
set_multiple_resources_1416572
branch
from
64a03fc
to
951d518
Compare
|
Some comments on commits lfu/manageiq@6c41fcc~...951d518 spec/lib/miq_automation_engine/service_models/miq_ae_service_manageiq-providers-cloud_manager-provision_spec.rb
|
|
Checked commits lfu/manageiq@6c41fcc~...951d518 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 lib/miq_automation_engine/service_models/mixins/miq_ae_service_miq_provision_mixin.rb
|
Merged
simaishi
pushed a commit
that referenced
this pull request
Mar 3, 2017
Add multiple_value option to expose_eligible_resources. (cherry picked from commit e5a8b38) https://bugzilla.redhat.com/show_bug.cgi?id=1422653
|
Euwe backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add multiple_value option to expose_eligible_resources to set multiple resources in options hash.
https://bugzilla.redhat.com/show_bug.cgi?id=1416572
cc @gmcculloug