Remove unwanted Application Events from Timeline #13669
Conversation
Use a new event_type for events used for internally supporting "live alerting" with the hawkular provider. By not declaring this event_type for the 'Application' event group (or any other group) it will not show up in the timeline.
|
@miq-bot add-label bug, providers/hawkular |
|
@lucasponce please review. |
|
LGTM |
|
cc @bronaghs |
| @@ -501,7 +501,7 @@ def self.expression_by_name(name) | |||
|
|
|||
| def self.raw_events | |||
| @raw_events ||= expression_by_name("event_threshold")[:options].find { |h| h[:name] == :event_types }[:values] + | |||
| ['hawkular_event'] | |||
| ['hawkular_alert'] | |||
There was a problem hiding this comment.
I think that @moolitayer was also interested on this.
This is just a renaming to only show desired events on ManageIQ.
I think this would not impact on the Datawarehouse provider, but just in case if you want to take a look as well.
|
Checked commit jshaughn@0a5b7c0 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
| @@ -20,7 +20,9 @@ def initialize(cfg = {}) | |||
| 'hawkular_datasource_remove.ok', | |||
| 'hawkular_deployment.ok', | |||
| 'hawkular_deployment_remove.ok', | |||
| 'hawkular_event' # # general purpose detail level event | |||
| 'hawkular_event', # general purpose detail level event | |||
| # filtered (not shown in timeline) | |||
There was a problem hiding this comment.
@jshaughn - if I understand the purpose of this PR correctly, it looks like the relevant event_type is now 'hawkular_alert' and no longer 'hawkular_event'. If that is the case, should 'hawkular event' be deleted from the white list?
There was a problem hiding this comment.
@bronaghs Good question but no, we need both. The issue was that the 'hawkular_event' event_type was being used both by the alerts mechanism (for internal use) and for legitimate events to be shown on the timeline. With this change the 'hawkular_alert' event_type will now be used exclusively for alerting, and not shown on the timeline, leaving the valid 'hawkular_event' events to be shown.
There was a problem hiding this comment.
Thanks for the clarification @jshaughn
Use a new event_type for events used for internally supporting "live alerting" with the hawkular provider.
By not declaring this event_type for the 'Application' event group (or any other group) it will not show up in the timeline.
Fixes Issue #13668
#13668