New class to for determining the availability of embedded ansible #13435
Conversation
| @@ -0,0 +1,24 @@ | |||
| class EmbeddedAnsible | |||
| APPLIANCE_ANSIBLE_DIRECTORY = "/opt/ansible-installer" | |||
There was a problem hiding this comment.
Still not sure on this path. We can always change later, so don't want it to hold up this PR, but just wanted to mention it. cc @carbonin I was thinking /opt/awx_installer or /opt/ansible-tower-installer. ansible-installer seems like a misnomer to me.
There was a problem hiding this comment.
So right now we will be installing the installer (sorry) manually so we will determine this path. When the installer is provided via rpm I assume they will install it wherever they decide so this will likely have to change either way.
|
I'm wondering if this should be more like the PdfGenerator in there being a NullEmbeddedAnsible. For PdfGenerator, this was useful because we had competing implementations, where none was a possible format. The calling code does everything through this plugin, so for PDFGenerator, all of the plugins have a "generate" method, where Null does nothing. Thoughts? Is that overkill, or would that be beneficial? |
gtanzillo
force-pushed
the
embedded_ansible
branch
from
76d38bd
to
3ac8c5a
Compare
| end | ||
|
|
||
| def self.enabled? | ||
| MiqServer.my_server(true).active_roles.include?(ANSIBLE_ROLE) |
There was a problem hiding this comment.
Prefer MiqServer.my_server(true).has_active_role?(ANSIBLE_ROLE)
gtanzillo
force-pushed
the
embedded_ansible
branch
from
3ac8c5a
to
2cf595c
Compare
|
Checked commit gtanzillo@2cf595c with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
| @@ -0,0 +1,23 @@ | |||
| class EmbeddedAnsible | |||
| APPLIANCE_ANSIBLE_DIRECTORY = "/opt/ansible-installer".freeze | |||
| ANSIBLE_ROLE = "embedded_ansible".freeze | |||
There was a problem hiding this comment.
Is this knowledge something that should live elsewhere?
Is there a more "official" place where we encode the exact role names?
|
One small comment. If that's fine I would want to get this in (I have some stuff I want to put in this class for configuration and such) 😄 |
I see where you're coming from but I don't see the need for it now. Do you think we could just keep the one class for now and push this logic down to a child class in the future if the need arises? |
Since Ansible will not be available initially (because it's not open source) we need a way to ask whether ansible is available from within the application so that certain features can be turned off if it's not.
This PR answers that by check if a particular directory exists. If it does, ansible is considered to be available.
https://www.pivotaltracker.com/story/show/137134397
/cc @carbonin @jrafanie