Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default values for metric rollup in chargeback specs #13240

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented Dec 19, 2016

replacing values of metrics by trait :with_data

@miq-bot add_label chargeback, test
@miq-bot assign @chrisarcand

@lpichler lpichler force-pushed the use_default_values_for_metric_rollup_in_chargeback_specs branch from d9d6b19 to 906129f Compare December 19, 2016 15:03
@miq-bot
Copy link
Member

miq-bot commented Dec 19, 2016

Checked commits lpichler/manageiq@826fd67~...906129f with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
4 files checked, 0 offenses detected
Everything looks good. 🍪

@chrisarcand
Copy link
Member

Nice, @lpichler 👍

@chrisarcand chrisarcand self-assigned this Dec 19, 2016
@chrisarcand chrisarcand merged commit 08521d6 into ManageIQ:master Dec 19, 2016
@chrisarcand chrisarcand added this to the Sprint 51 Ending Jan 2, 2017 milestone Dec 19, 2016
@lpichler lpichler deleted the use_default_values_for_metric_rollup_in_chargeback_specs branch March 3, 2017 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants