Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert summary screen images to fonticons and SVGs #13222

Merged
merged 1 commit into from
Dec 19, 2016
Merged

Convert summary screen images to fonticons and SVGs #13222

merged 1 commit into from
Dec 19, 2016

Conversation

epwinchell
Copy link
Contributor

@epwinchell epwinchell commented Dec 16, 2016

This PR replaces PNG files with font icons and SVG images (for Vendor and OS) in the summary screens.

It also adds 10 new font icons to the "product" font family:

  • product-cloud_object_store
  • product-network_port
  • product-file_share
  • product-resource
  • product-configured_system
  • product-parameter
  • product-application
  • product-firewall
  • product-genealogy
  • product-output

https://www.pivotaltracker.com/n/projects/1613907/stories/123185371

screen shot 2016-12-16 at 11 06 44 am

screen shot 2016-12-16 at 12 17 27 pm

screen shot 2016-12-16 at 11 07 24 am

@epwinchell
Copy link
Contributor Author

@miq-bot add_label ui, enhancement

@epwinchell
Copy link
Contributor Author

@miq-bot assign @himdel

@epwinchell
Copy link
Contributor Author

@miq-bot add_label euwe/no

@epwinchell
Copy link
Contributor Author

cc @dclarizio @martinpovolny

@himdel himdel added the euwe/no label Dec 19, 2016
@@ -10,7 +10,7 @@ def textual_compliance_status
else
compliant = @record.last_compliance_status
date = @record.last_compliance_timestamp
h[:image] = "100/#{compliant ? "check" : "x"}.png"
h[:icon] = "#{compliant ? "pficon pficon-ok" : "pficon pficon-error-circle-o"}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May want to drop the outer quotes .. h[:icon] = compliant ? "pficon pficon-ok" : "pficon pficon-error-circle-o"

@miq-bot
Copy link
Member

miq-bot commented Dec 19, 2016

Checked commit https://github.com/epwinchell/manageiq/commit/a46960d567024ddcde183574bddf9da5a378440d with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
56 files checked, 23 offenses detected

app/helpers/cloud_object_store_container_helper/textual_summary.rb

app/helpers/cloud_object_store_object_helper/textual_summary.rb

app/helpers/cloud_volume_helper/textual_summary.rb

app/helpers/cloud_volume_snapshot_helper/textual_summary.rb

app/helpers/ems_infra_helper/textual_summary.rb

app/helpers/host_helper/textual_summary.rb

app/helpers/middleware_server_helper/textual_summary.rb

  • ❗ - Line 63, Col 10 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.

app/helpers/ontap_logical_disk_helper/textual_summary.rb

app/helpers/service_helper/textual_summary.rb

app/helpers/storage_helper/textual_summary.rb

app/helpers/vm_cloud_helper/textual_summary.rb

app/helpers/vm_helper/textual_summary.rb

@himdel
Copy link
Contributor

himdel commented Dec 19, 2016

Tested (hopefully) all the UI summary screens, not seeing any more breakage.. will merge when green 👍

@himdel himdel merged commit 1b08479 into ManageIQ:master Dec 19, 2016
@himdel himdel added this to the Sprint 51 Ending Jan 2, 2017 milestone Dec 19, 2016
@epwinchell
Copy link
Contributor Author

🎉 🎈

@epwinchell epwinchell deleted the summary_screen_icons branch March 20, 2019 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants