-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert summary screen images to fonticons and SVGs #13222
Conversation
@miq-bot add_label ui, enhancement |
@miq-bot add_label euwe/no |
@@ -10,7 +10,7 @@ def textual_compliance_status | |||
else | |||
compliant = @record.last_compliance_status | |||
date = @record.last_compliance_timestamp | |||
h[:image] = "100/#{compliant ? "check" : "x"}.png" | |||
h[:icon] = "#{compliant ? "pficon pficon-ok" : "pficon pficon-error-circle-o"}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May want to drop the outer quotes .. h[:icon] = compliant ? "pficon pficon-ok" : "pficon pficon-error-circle-o"
Checked commit https://github.com/epwinchell/manageiq/commit/a46960d567024ddcde183574bddf9da5a378440d with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 app/helpers/cloud_object_store_container_helper/textual_summary.rb
app/helpers/cloud_object_store_object_helper/textual_summary.rb
app/helpers/cloud_volume_helper/textual_summary.rb
app/helpers/cloud_volume_snapshot_helper/textual_summary.rb
app/helpers/ems_infra_helper/textual_summary.rb
app/helpers/host_helper/textual_summary.rb
app/helpers/middleware_server_helper/textual_summary.rb
app/helpers/ontap_logical_disk_helper/textual_summary.rb
app/helpers/service_helper/textual_summary.rb
app/helpers/storage_helper/textual_summary.rb
app/helpers/vm_cloud_helper/textual_summary.rb
app/helpers/vm_helper/textual_summary.rb
|
Tested (hopefully) all the UI summary screens, not seeing any more breakage.. will merge when green 👍 |
🎉 🎈 |
This PR replaces PNG files with font icons and SVG images (for Vendor and OS) in the summary screens.
It also adds 10 new font icons to the "product" font family:
https://www.pivotaltracker.com/n/projects/1613907/stories/123185371