Notify only a group of users when notifying about MiqRequest #13051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem: Consider tenant with two groups. Each group has a user. Both have a role limiting the vms they see by ownership. When one user orders a vm, the other one does not see it. The problem was that the notification was created previously to both users. The root cause was that both user can see the given MiqProvisionRequest. We cannot fix the root cause directly. As we cannot tell up-front what users are gonna see the VM, before it is created -> thus we cannot tell what users shall see the given MiqProvisionRequest. The MiqProvisionRequest are still seen by both users. However only relevant users are notified about it.
|
Checked commit isimluk@9b5af98 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
chessbyte
pushed a commit
that referenced
this pull request
Dec 8, 2016
Notify only a group of users when notifying about MiqRequest (cherry picked from commit 9d5adc4) https://bugzilla.redhat.com/show_bug.cgi?id=1397465
|
Euwe Backport details: $ git log -1
commit f3db579e4d9c0628774fb6ef9f80c4cc717ed3b7
Author: Gregg Tanzillo <gtanzill@redhat.com>
Date: Thu Dec 8 14:54:06 2016 -0500
Merge pull request #13051 from isimluk/rhbz#1397465
Notify only a group of users when notifying about MiqRequest
(cherry picked from commit 9d5adc4fd63ec30e208fc81fbc8b699bf9e5009b)
https://bugzilla.redhat.com/show_bug.cgi?id=1397465 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
https://bugzilla.redhat.com/show_bug.cgi?id=1397465
Consider tenant with two groups. Each group has a user. Both have a role limiting the vms they see by ownership. When one user orders a vm, the other one does not see it.
The problem was that the notification was created previously to both users.
The Cause
The root cause was that both user can see the given MiqProvisionRequest.
The Fix
We cannot fix the root cause directly. As we cannot tell up-front what users are gonna see the VM, before it is created -> thus we cannot tell what users shall see the given MiqProvisionRequest.
The MiqProvisionRequest are still seen by both users. However only relevant users are notified about it.
@miq-bot add_label blocker, bug, core, euwe/yes
@miq-bot assign @gtanzillo