Don't queue ntp reload on newly created zones #12974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The record has not changed, so no need to lookup active miq servers
carbonin
approved these changes
Dec 5, 2016
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you create a new zone, no reason to ask all active servers to reload their ntp settings.
you see, when creating a zone, the old settings were blank, so it always thinks the settings have changed.
@Fryguy / @carbonin not sure if you feel safer always kicking it off.
In test, these queries get called for every zone created (which is a bunch)
In production, probably not so many.
(but this PR is because it was causing problems for me in tests)