ServiceOrder deep copy #12945
ServiceOrder deep copy #12945
Conversation
| # Should be put back into the Cart state | ||
| new_service_order.state = STATE_CART | ||
| new_service_order.miq_requests = miq_requests.collect do |request| | ||
| request.class.send(:create, request.attributes.except("id", "name", "approval_state", "request_state", |
There was a problem hiding this comment.
@jntullo - Possibly these attributes should be moved to a constant.
| "placed_on")) | ||
| end | ||
| new_attributes.each do |attr, value| | ||
| new_service_order.send("#{attr}=", value) |
There was a problem hiding this comment.
This worries me a bit - maybe because we're implicitly trusting what is coming in to the method new_attributes = {}. I understand the save! would validate and throw any exception. Maybe I'm being a bit too cautious.
@gmcculloug do you have any thoughts?
There was a problem hiding this comment.
Maybe I'd feel better if we validated that the new_attributes hash included only attributes specific to the new_service_order and then passed them to the send method? - Again open to any other thoughts on this.
move request attributes to a constant validating the attributes
|
@tinaafitz Please review |
|
@jntullo |
|
@gmcculloug no |
|
@gmcculloug @jntullo Looks good. |
|
Checked commit jntullo@3dd226a with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
The SUI will be adding the ability to re-order / duplicate an order (see here and here). As a result, we need a way to deep copy a service order to include its requests.
It only copies the necessary attributes of an miq_request so that it resets attributes such as
approval_stateandrequest_stateto the defaults.@miq-bot add_label enhancement, services
@miq-bot assign @gmcculloug
cc: @syncrou