Update cluster when modified #12927
Merged
Update cluster when modified #12927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we change cluster for a specific vm we were not able to fetch proper cluster information. We were not able to get this information from the event due to code limitation. Now we fetch all the clusters and datacenters so we have enough information to update the vm. This patch fixes: https://bugzilla.redhat.com/1397503
|
Checked commit pkliczewski@80f3bf9 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 app/models/manageiq/providers/redhat/infra_manager/refresher.rb
spec/models/manageiq/providers/redhat/infra_manager/refresher_target_vm_spec.rb
|
|
@borod108 please review |
|
I'm good with this to fix the bug but we should try to fix the event limitation if we can to return the correct cluster. @pkliczewski what event gets raised when a VMs' cluster is changed? I'm a little worried that we're reducing the effectiveness of RHEV targeted refresh if between this PR and #12959 we're pulling back all datacenters, hosts, and clusters |
simaishi
pushed a commit
that referenced
this pull request
Jan 10, 2017
Update cluster when modified (cherry picked from commit 588b5f9) https://bugzilla.redhat.com/show_bug.cgi?id=1411791
|
Euwe backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we change cluster for a specific vm we were not able to
fetch proper cluster information. We were not able to get this
information from the event due to code limitation.
Now we fetch all the clusters and datacenters so we have enough
information to update the vm.
This patch fixes:
https://bugzilla.redhat.com/1397503