Fix position of chart menu in C&U when clicking close to right edge #12922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PanSpagetka
changed the title
|
Checked commit PanSpagetka@5917f02 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
chessbyte
reviewed
Nov 30, 2016
| @@ -656,7 +656,9 @@ function miqBuildChartMenuEx(col, row, _value, category, series, chart_set, char | |||
| $("#" + pid).append("<li><a id='"+btoa(JSON.stringify(row_col_chart_index))+"' href='#' onclick='miqChartMenuClick(this.id)'>" + menu_title + "</a></li>"); | |||
| } | |||
|
|
|||
| chartmenu_el.css({'left': ManageIQ.mouse.x, 'top': ManageIQ.mouse.y}); | |||
| //chart menu has min-width: 160 a has two levels | |||
| var x_possition = (ManageIQ.mouse.x > $(window).width() - 320) ? $(window).width() - 320 : ManageIQ.mouse.x; | |||
There was a problem hiding this comment.
typo: possition should be position
|
Fix the typo, please, then we are good to merge. |
PanSpagetka
force-pushed
the
fix-cu-chart-menu-right-position
branch
from
5917f02
to
a99e4f9
Compare
simaishi
pushed a commit
that referenced
this pull request
Jan 9, 2017
…sition Fix position of chart menu in C&U when clicking close to right edge (cherry picked from commit 3f6d03c) https://bugzilla.redhat.com/show_bug.cgi?id=1411471
|
Euwe backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix position of chart menu in C&U charts. Previously menu position was fixed to mouse position, but when you clicked near right border of the screen menu was situated outside of screen.
Screenshot
Links [Optional]
https://bugzilla.redhat.com/show_bug.cgi?id=1389319
Steps for Testing/QA [Optional]
Go to C&U and click on chart near right border.
https://bugzilla.redhat.com/show_bug.cgi?id=1389319