Emit notifications only when user is authorized to see concerned object #12771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isimluk
force-pushed
the
rhbz#1394283
branch
5 times, most recently
from
5e8ce6d
to
8b65ddc
Compare
|
Checked commit isimluk@8b65ddc with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
|
@simaishi Please create Euwe BZ for https://bugzilla.redhat.com/show_bug.cgi?id=1394283 |
chessbyte
pushed a commit
that referenced
this pull request
Nov 22, 2016
Emit notifications only when user is authorized to see concerned object (cherry picked from commit 538b938) https://bugzilla.redhat.com/show_bug.cgi?id=1394283
|
Euwe Backport details: $ git log -1
commit 95b74a8a55fcbd5ebd93717eb58775b4c9ea211f
Author: Gregg Tanzillo <gtanzill@redhat.com>
Date: Tue Nov 22 08:51:42 2016 -0500
Merge pull request #12771 from isimluk/rhbz#1394283
Emit notifications only when user is authorized to see concerned object
(cherry picked from commit 538b938dd4b81c5aff0347b9787da55622f97d3e)
https://bugzilla.redhat.com/show_bug.cgi?id=1394283 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1394283
We shall not send a notification to the user, who is not authorized to see the object.
In future, we may want to handle the notification's subscribers in async queue.
@miq-bot add_label bug, blocker, core, euwe/no
@miq-bot assign @gtanzillo