Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container SSA: splitting pod deletion #12750

Merged
merged 1 commit into from
Nov 21, 2016

Conversation

enoodle
Copy link

@enoodle enoodle commented Nov 18, 2016

This is just separating the pod deletion and skipping it altogether if no pod was created before.

cc @simon3z

This to prevent crush-like failure when aborting before a pod was
created - This causes kubeclient to return an empty pods list that will
fail when reading the annotation.
@miq-bot
Copy link
Member

miq-bot commented Nov 18, 2016

Checked commit enoodle@31a8cb0 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
1 file checked, 1 offense detected

app/models/manageiq/providers/kubernetes/container_manager/scanning/job.rb

  • ❕ - Line 176, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for delete_pod is too high. [34.73/20]

@roliveri
Copy link
Member

@enoodle Should this be back ported to euwe and/or darga?

@enoodle
Copy link
Author

enoodle commented Nov 21, 2016

@roliveri this doesn't change much feature, but the user experience: instead of waiting 5/10 minutes to see the failed scan it will be more immediate and the error will be more clear.
I think that it is important to add to euwe and darge.
@miq-bot add_label euwe/yes

cc @simon3z

@simon3z
Copy link
Contributor

simon3z commented Nov 21, 2016

Just euwe. cc @Loicavenel in case he thinks otherwise.

@simon3z
Copy link
Contributor

simon3z commented Nov 21, 2016

Temporarily removing darga (we can re-add in case @Loicavenel thinks otherwise).

@miq-bot remove_label darga/yes

@miq-bot miq-bot removed the darga/yes label Nov 21, 2016
@roliveri roliveri merged commit 995b2a7 into ManageIQ:master Nov 21, 2016
@roliveri roliveri added this to the Sprint 50 Ending Dec 5, 2016 milestone Nov 21, 2016
@simaishi
Copy link
Contributor

simaishi commented Jan 6, 2017

@enoodle is there a BZ for this?

@enoodle
Copy link
Author

enoodle commented Jan 8, 2017

@simaishi This is not a bugfix so no. I don't think its important to backport to euwe. I would have been nice back then but now its not important anymore.
@miq-bot remove_label euwe/yes

@miq-bot miq-bot removed the euwe/yes label Jan 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants