Add settings key to disable console proxy

[martinpovolny]

https://bugzilla.redhat.com/show_bug.cgi?id=1399369

Using 'server.console_proxy_disabled' set to 'true' the proxying can be
disabled even if the display ticket is being requested by a different
server than the one that originated the request.

This allows the server to behave the same as before Euwe.

This is an addition to the 2 keys:

'server.proxy_port.start', defaults to 6000
'server.proxy_port.end', defaults to 7000

that allow setting of the port range for the console proxy.

ping @skateman

[Fryguy]

No need for try. The server key will always exist because

manageiq/config/settings.yml

Line 1035 in edb5ac0

:server:

[martinpovolny]

Removed. Thx.

[miq-bot]

Checked commits martinpovolny/manageiq@64e04b9~...b2ac616 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
1 file checked, 0 offenses detected
Everything looks good. 🍪

[martinpovolny]

ping @Fryguy. Can we merge this one?

[Fryguy]

cc @yrudman (not sure if you need to add this one to your spreadsheet as a "hidden" setting. Merging anyway.

[yrudman]

1. ::Settings.server.proxy_port is not present in settings.yml and calls ::Settings.server.proxy_port.start and ::Settings.server.proxy_port.end will throw errors. I would suggest to add default values to settings.yml and remove it from code.
   If we do not want to add above values to settings.tml than original code should be used:
   ::Settings.server.proxy_port.try(:start)

2. I will add ::Settings.server.console_proxy_disabled to the list of hidden values if we do not want to add default value to settings.yml.

[Fryguy]

@yrudman Can you make the follow up PR?

[yrudman]

ok

[simaishi]

Euwe backport details:

$ git log -1
commit b603479542468929d05cd9470ad3abcac7305329
Author: Jason Frey <fryguy9@gmail.com>
Date:   Mon Nov 28 14:42:54 2016 -0500

    Merge pull request #12675 from martinpovolny/console_config
    
    Add settings key to disable console proxy
    (cherry picked from commit 5271c9157f255405b9af865edd02a8be7a461b3c)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1399677