Add ipv4 ipv6 selection to Subnet view

[andyvesel]

https://bugzilla.redhat.com/show_bug.cgi?id=1394286

1. Added a ipv4/ipv6 selection field to Subnet create page
   

2. Locked ipv4/ipv6 and CIDR fields on Subnet edit page
   

[chessbyte]

Screenshots please

[dclarizio]

@andyvesel please rebase and repush, I think the expression tests were fixed in another PR. Also, agree with @chessbyte, needs screenshots. Thx, Dan

[dclarizio]

@andyvesel should the IP version be a drop down choice of 4 and 6? Also, should there be some code to handle the new value coming in?
@Ladas can you please review?

[Ladas]

@andyvesel @dclarizio yes, it should be a dropdown, I don't expect anything else than IPv4 and IPv6 can be really there? ( at least for a next century :-) )

Backend was already merged? Usually we mark the backed PR as a dependency and a UI PR is a WIP until backend is merged

[andyvesel]

@Ladas, is this the right backend PR?
#12561

[Ladas]

@andyvesel doesn't seems to be, those are just logs. With you PR, does it actually store the right IP version to OpenStack?

[miq-bot]

Checked commits andyvesel/manageiq@bd4d1e6~...7602272 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
0 files checked, 0 offenses detected
Everything looks good. 👍

[andyvesel]

@Ladas can you review please?

[Ladas]

looks good 👍

[dclarizio]

@andyvesel if this was changed to a drop down, can you replace the screen shot above? Thx, Dan

[andyvesel]

@dclarizio done

[tzumainn]

@miq-bot add_label blocker
@miq-bot add_label bug

[simaishi]

Euwe backport details:

$ git log -1
commit b8909f2b50f60f00b49180d570a8d2a079e340d6
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Tue Dec 6 14:21:12 2016 -0500

    Merge pull request #12650 from andyvesel/add_ipv4_ipv6_selection_to_subnet_view
    
    Add ipv4 ipv6 selection to Subnet view
    (cherry picked from commit 464fe051be7885b2bc4f8cd6a2ed4044f6b4721f)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1402162