[EUWE] add missing ActiveSupport::Concern to middle module #12585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @Fryguy @chrisarcand another reason, why it would be good to make the SupportsFeatureMixin more robust. With the implementation in #11322 this would not have happened |
|
Checked commit durandom@33bb16f with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
|
Travis failure is the result of UI spec needing to be expanded in #11899. Merging to remove major spec failures. |
TBH I don't see that as a valid reason; requiring that these modules use AR::Concern is a perfectly fine solution to me (this coming from the guy that really dislikes Concerns). If anything it would make things more consistent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backporting this #11899 resulted in 🔴 CI, because this missing
extend ActiveSupport::ConcerninManageIQ::Providers::Redhat::InfraManager::Vm::Operationswas introduced in another PR that should not be backported.