Fix missing Smart State Analysis button on Cloud Instances list view #12559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label ui,bug |
|
Before fix: |
|
Checked commits jzigmund/manageiq@3ff61f3~...e63f2a0 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 spec/helpers/application_helper/buttons/basic_image_spec.rb
|
|
@romanblanco could you please review this ? |
|
Tested in UI, fixes the issue 👍 |
|
Euwe backport conflict: $ git diff
diff --cc app/helpers/application_helper/toolbar/vm_clouds_center.rb
index e591880,3484666..0000000
--- a/app/helpers/application_helper/toolbar/vm_clouds_center.rb
+++ b/app/helpers/application_helper/toolbar/vm_clouds_center.rb
@@@ -25,8 -25,8 +25,13 @@@ class ApplicationHelper::Toolbar::VmClo
:url_parms => "main_div",
:confirm => N_("Perform SmartState Analysis on the selected items?"),
:enabled => false,
++<<<<<<< HEAD
+ :onwhen => "1+",
+ :klass => ApplicationHelper::Button::VmInstanceScan),
++=======
+ :klass => ApplicationHelper::Button::BasicImage,
+ :onwhen => "1+"),
++>>>>>>> fb15bf9... Merge pull request #12559 from jzigmund/bz1389055-smartstate_analysis_missing
button(
:instance_compare,
'product product-compare fa-lg',
* Unmerged path app/helpers/application_helper/button/vm_instance_template_scan.rb |
|
@jzigmund Please resolve conflict and make Euwe-specific PR (referencing this one) or suggest other PRs to backport. |
jzigmund
pushed a commit
to jzigmund/manageiq
that referenced
this pull request
Jan 11, 2017
…analysis_missing Fix missing Smart State Analysis button on Cloud Instances list view (cherry picked from commit fb15bf9)
|
Backported to Euwe via #13422 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use different class for
instance_scanto display Smart State Analysis on Instance list view as the class used for one Instance (where we can detect if the button should be visible or not - depends on support of Smart State on the instance).https://bugzilla.redhat.com/show_bug.cgi?id=1389055