Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable export button when no profile is selected #12174

Merged

Conversation

Jaganathancse
Copy link
Contributor

Export button is enabled only if profiles are selected in Control
Import/Export screen.

@himdel
Copy link
Contributor

himdel commented Nov 16, 2016

@Jaganathancse can you also remove that - observe = {:url => url}.to_json please? Since you've removed the last place that was using that variable..

Export button is enabled only if profiles are selected in Control
Import/Export screen.
@miq-bot
Copy link
Member

miq-bot commented Nov 16, 2016

Checked commit Jaganathancse@510b6b3 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
1 file checked, 0 offenses detected
Everything looks good. 🍪

@Jaganathancse
Copy link
Contributor Author

@himdel I have removed observe = {:url => url}.to_json. please verify.

@himdel
Copy link
Contributor

himdel commented Nov 21, 2016

So.. this works in the UI, switching the choice in the select repaints the whole screen so correctly resets the button.

If this were for keeps, I'd still encourage you to move the JS to a function, and to use .on('change', fn) instead of .change(fn) but the form is on the "being converted to angular" list anyway and it's a minor issue.

Merging 👍 :)

@himdel himdel merged commit eaf5abc into ManageIQ:master Nov 21, 2016
@himdel himdel added the euwe/no label Nov 21, 2016
@himdel himdel added this to the Sprint 50 Ending Dec 5, 2016 milestone Nov 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants