-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding lenovo logger for Lenovo provider #12084
Conversation
As an aside, we need to figure out a way for providers to register their logger with the core app. /cc @durandom |
Checked commit blomquisg@a64af1c with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 lib/vmdb/loggers.rb
|
I thought we did logging in a different way than with the |
LGTM 👍 |
@blomquisg I had ideas about not creating separate $loggers at all. Basically, each plugin could be "given" a dedicated logger object by the server. Then the code within the plugin would call |
^^ This would of course depend on the Settings pluggability...I have to find time to review @durandom's stuff :) |
@Fryguy Sounds like a great idea. |
@juliancheal said:
None that I know of ... |
@Fryguy said:
heh, I was gonna respond about Settings ... but you beat me |
Adding
$lenovo_log
for the Lenovo provider logger.