Support provider name & template name to uniquely identify a template

[mkanoor]

Optionally support 'ansible_provider_name' to uniquely identify a
job template. This is needed where you might have multiple Ansible
Towers with the same named templates.

Links

• https://bugzilla.redhat.com/show_bug.cgi?id=1378606

Testing:
Bugzilla provides the details

[mfalesni]

Just noted this PR in the bug, I was wondering why is provider name better than provider ID? Provider ID (or GUID) cannot change for one given provider but name can.

[mkanoor]

@mfalesni
ID can uniquely identify a template or rather any object in the vmdb.
In the customers case they have names that they are picking from the service dialogs.

When you specify a template you can pass one of the following to uniquely identify a job template

1. job_template object passed in using ConfigurationScript::job_template=<>
2. job_template_id
3. job_template_name & ansible_provider_name
4. job_template_name

This PR adds option 3 from above.

[gmcculloug]

@bzwei Please review

[bzwei]

@mkanoor should the provider name key ansinble_tower_provider_name? Do we need the alternative name with prefix dialog_?

[miq-bot]

Checked commits mkanoor/manageiq@23f8ac3~...4fc0d67 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
2 files checked, 1 offense detected

db/fixtures/ae_datastore/ManageIQ/ConfigurationManagement/AnsibleTower/Operations/StateMachines/Job.class/methods/launch_ansible_job.rb

• ❕ - Line 98, Col 121 - Metrics/LineLength - Line is too long. [121/120]

[mkanoor]

@bzwei
Changes made. There is lot of code duplication in spec, which I think we can cleanup in a separate PR.

[bzwei]

@mkanoor definitely we should simplify the spec. I am OK with a separate PR.

[simaishi]

Euwe backport details:

$ git log -1
commit 166c703906fed68236023d53f702b431e4a1ef8b
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Mon Nov 28 14:12:23 2016 -0500

    Merge pull request #11669 from mkanoor/bugzilla_1378606
    
    Support provider name & template name to uniquely identify a template
    (cherry picked from commit 76c643b434e10061a7d5e93db62f3eff17ecfacf)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1411359