Include SupportsFeatureMixin for Hosts #11661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to fix an issue while trying to access Host summary screen, need to include supportsfeature mixin to be able to enable/disable Power reset & shutdown buttons.
|
@h-kataria thanks for fixing this. LGTM For completeness: the bug was introduced here #11054 and it looks like the GenericFeatureButton is only used in |
|
Checked commit h-kataria@4b2f036 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
|
Kicking the build |
chessbyte
pushed a commit
that referenced
this pull request
Oct 4, 2016
…in_for_hosts Include SupportsFeatureMixin for Hosts (cherry picked from commit c27de6f)
|
Euwe Backport details: $ git log
commit e944587aed07f1f7d9c831421f5fee481cadce18
Author: Dan Clarizio <dclarizi@redhat.com>
Date: Mon Oct 3 12:58:36 2016 -0700
Merge pull request #11661 from h-kataria/include_supports_feature_mixin_for_hosts
Include SupportsFeatureMixin for Hosts
(cherry picked from commit c27de6fd674f3c55603748364a66d70f649eb5b6) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix an issue while trying to access Host summary screen, need to include supportsfeaturemixin to be able to enable/disable Power reset & shutdown buttons.
@durandom @dclarizio please review/merge. This issue is causing an error while trying to access Host summary screens.