Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate a csv of features supported across all models #11281

Merged
merged 1 commit into from
Sep 21, 2016

Conversation

durandom
Copy link
Member

@durandom durandom commented Sep 15, 2016

execute as ruby tools/feature_support_matrix.rb

A sample Google Docs output is here

Model Associate a Floating IP Basic control operations CloudTenant mapping Deletion Disassociate a Floating IP Discovery of Managers for a Provider Evacuation Query for events Launch Cockpit UI Live Migration Migration Provisioning Reconfiguration Regions of a Provider Resizing Retirement Smartstate Analaysis
VmOrTemplate x
Vm x x x x
ManageIQ::Providers::InfraManager::Vm x x x x
ManageIQ::Providers::Vmware::InfraManager::Vm x x x x x
ManageIQ::Providers::Redhat::InfraManager::Vm x x x x
ManageIQ::Providers::Microsoft::InfraManager::Vm x x x x
VmXen x x x x
ManageIQ::Providers::CloudManager::Vm x x x x
ManageIQ::Providers::Openstack::CloudManager::Vm x x x x x x x x x
ManageIQ::Providers::Google::CloudManager::Vm x x x x
ManageIQ::Providers::Amazon::CloudManager::Vm x x x x
ManageIQ::Providers::Vmware::CloudManager::Vm x x x x
ManageIQ::Providers::Azure::CloudManager::Vm x x x x x
VmServer x x x x
MiqTemplate x
ManageIQ::Providers::InfraManager::Template x
ManageIQ::Providers::Openstack::InfraManager::Template x x
ManageIQ::Providers::Vmware::InfraManager::Template x x x
ManageIQ::Providers::Redhat::InfraManager::Template x x x
ManageIQ::Providers::Microsoft::InfraManager::Template x x
TemplateXen x
ManageIQ::Providers::CloudManager::Template x
ManageIQ::Providers::Openstack::CloudManager::Template x x x
ManageIQ::Providers::Google::CloudManager::Template x x
ManageIQ::Providers::Amazon::CloudManager::Template x x
ManageIQ::Providers::Vmware::CloudManager::Template x
ManageIQ::Providers::Azure::CloudManager::Template x x x
Service x
ServiceOrchestration x
ServiceAnsibleTower x
ManageIQ::Providers::Vmware::InfraManager x x
ManageIQ::Providers::Redhat::InfraManager x
ManageIQ::Providers::Microsoft::InfraManager x
ManageIQ::Providers::Openstack::CloudManager x x
ManageIQ::Providers::Google::CloudManager x x
ManageIQ::Providers::Amazon::CloudManager x x x
ManageIQ::Providers::Azure::CloudManager x x x

@durandom
Copy link
Member Author

@miq-bot assign blomquisg
@miq-bot add_label pluggable providers

cc @jameswnl @gauravaradhye

@blomquisg
Copy link
Member

/cc @mfeifer

@mfeifer
Copy link
Contributor

mfeifer commented Sep 19, 2016

❤️

def usage
<<-USAGE
Usage:
`bin/rails r tools/feature_support_matrix.rb`
Copy link
Member

@jrafanie jrafanie Sep 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest putting this at the top so you can invoke this with plain ruby:
require File.expand_path('../config/environment', __dir__)

This will load rails in a way that's nearly 100% identical as bin/rails runner. Runner is for inline ruby strings, not actual files. See also #4307.

the side effect is you don't have to deal with rails runner intercepting any ARGs you pass to the script.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also easier to invoke
ruby tools/feature_support_matrix.rb

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since i brought it up, I'll fix up some of the existing scripts in tools that do the bin/rails runner way.

jrafanie added a commit to jrafanie/manageiq that referenced this pull request Sep 20, 2016
Benefits:
* rails runner is for shebang lines or inline ruby, see ManageIQ#4307
* We don't have to check if rails is loaded.
* Can be run outside rails root directory via ruby.
* We don't need -- to avoid rails runner modifying our args.
* Less typing.
* Existing bin/rails runner callers with args just work:

`ruby tools/purge_orphaned_tag_values.rb -s 100`

Or, the old way:
`bin/rails runner tools/purge_orphaned_tag_values.rb -- -s 100`

Discovered while reviewing: ManageIQ#11281
def usage
<<-USAGE
Usage:
`ruby tools/feature_support_matrix.rb`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 👍

@jrafanie
Copy link
Member

@durandom Can you reword the commit message to say ruby instead of bin/rails runner? I already updated the description of the PR but the commit is still lying. Note, bin/rails runner still works but is not very friendly.

execute as `ruby tools/feature_support_matrix.rb`
@miq-bot
Copy link
Member

miq-bot commented Sep 20, 2016

Checked commit durandom@0fa1af9 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
1 file checked, 0 offenses detected
Everything looks good. 🍰

@blomquisg blomquisg merged commit 9cec95d into ManageIQ:master Sep 21, 2016
@blomquisg blomquisg added this to the Sprint 47 Ending Oct 3, 2016 milestone Sep 21, 2016
@durandom durandom deleted the supports_feature_overview branch December 8, 2016 22:18
@durandom durandom mentioned this pull request Apr 21, 2017
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants