Review response: Used ternary operator

ManageIQ · Nov 1, 2016 · 410399c · 410399c
1 parent 2812be3
commit 410399c
Showing 1 changed file with 1 addition and 5 deletions.
diff --git a/app/helpers/application_helper/toolbar_builder.rb b/app/helpers/application_helper/toolbar_builder.rb
@@ -85,11 +85,7 @@ def toolbar_button(inputs, props)
     button_class = inputs[:klass] || ApplicationHelper::Button::Basic
     props[:options] = inputs[:options] if inputs[:options]
     button = button_class.new(@view_context, @view_binding, @instance_data, props)
-    if button.skipped?
-      nil
-    else
-      apply_common_props(button, inputs)
-    end
+    button.skipped? ? nil : apply_common_props(button, inputs)
   end
 
   # Build select button and its child buttons