Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated RBAC and product features to support new structure #1090

Merged
merged 2 commits into from
Oct 17, 2017
Merged

Updated RBAC and product features to support new structure #1090

merged 2 commits into from
Oct 17, 2017

Conversation

chalettu
Copy link
Contributor

@chalettu chalettu commented Oct 16, 2017

@chalettu
Copy link
Contributor Author

@miq-bot add_label enhancement

@chriskacerguis chriskacerguis self-assigned this Oct 16, 2017
@miq-bot
Copy link
Member

miq-bot commented Oct 16, 2017

Checked commits https://github.com/chalettu/manageiq-ui-service/compare/0f1d1f4847fd61ed6ef27c8eca168027237831f3~...7961cab070baea349b9b2329caab195cc2b88eb5 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@chalettu
Copy link
Contributor Author

This PR is dependent on ManageIQ/manageiq#16212 getting merged first.

@chalettu
Copy link
Contributor Author

@miq-bot add_label fine/no

Copy link
Member

@AllenBW AllenBW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Soooooooo a few hasAny have been replace with has but ultimately being more explicit communicating the product features that gate functionality is probably a better approach.

This is lookin' super shiny @chalettu 🌮 💃

@AllenBW AllenBW added this to the Sprint 72 Ending Oct 30, 2017 milestone Oct 17, 2017
@AllenBW
Copy link
Member

AllenBW commented Oct 17, 2017

Adding unmergable because of dependency on other pr ManageIQ/manageiq#16212

@chalettu
Copy link
Contributor Author

@miq-bot remove_label unmergeable

@chriskacerguis chriskacerguis merged commit 798ea56 into ManageIQ:master Oct 17, 2017
@chriskacerguis chriskacerguis mentioned this pull request Oct 17, 2017
29 tasks
AllenBW added a commit to AllenBW/manageiq-ui-service that referenced this pull request Oct 17, 2017
AllenBW added a commit to AllenBW/manageiq-ui-service that referenced this pull request Oct 18, 2017
AllenBW added a commit to AllenBW/manageiq-ui-service that referenced this pull request Oct 18, 2017
AllenBW added a commit to AllenBW/manageiq-ui-service that referenced this pull request Oct 18, 2017
AllenBW added a commit to AllenBW/manageiq-ui-service that referenced this pull request Oct 18, 2017
AllenBW added a commit to AllenBW/manageiq-ui-service that referenced this pull request Oct 18, 2017
AllenBW added a commit to AllenBW/manageiq-ui-service that referenced this pull request Oct 18, 2017
@chalettu chalettu deleted the sui_rbac branch November 21, 2017 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants