Replaced validate_* methods calls by supports_* for snapshot operations #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label wip |
gauravaradhye
changed the title
|
@miq-bot remove_label wip |
|
@gauravaradhye @durandom is an invalid assignee, ignoring... |
|
Checked commits gauravaradhye/manageiq-ui-classic@3717205~...b9d8d60 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
durandom
approved these changes
Feb 21, 2017
|
Hmm, well it did not. The error message is a different one. Is that change on purpose? Did anyone actually run the specs? |
This was referenced Feb 22, 2017
Merged
apparently not 😭 my fault |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to the refactoring changes in PR ManageIQ/manageiq#13992