Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ProvisionCustomizeHelper helper method access in VM controllers #2923

Merged
merged 2 commits into from
Dec 4, 2017
Merged

Fix ProvisionCustomizeHelper helper method access in VM controllers #2923

merged 2 commits into from
Dec 4, 2017

Conversation

AparnaKarve
Copy link
Contributor

Include the helper ProvisionCustomizeHelper in VmCommon in order to make the helper methods accessible in VM controllers.

https://bugzilla.redhat.com/show_bug.cgi?id=1515710

@miq-bot
Copy link
Member

miq-bot commented Dec 4, 2017

Checked commits AparnaKarve/manageiq-ui-classic@fa1a373~...e89717d with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 2 offenses detected

app/controllers/vm_common.rb

@AparnaKarve
Copy link
Contributor Author

@miq-bot add_label bug,gaprindashvili/yes

@dclarizio dclarizio self-assigned this Dec 4, 2017
@lfu
Copy link
Member

lfu commented Dec 4, 2017

Tested the fix. Was able to upload a sysprep file and get the content of the uploaded file in the UI 👍

sysprep content

@dclarizio dclarizio merged commit 3f552a2 into ManageIQ:master Dec 4, 2017
@dclarizio dclarizio added this to the Sprint 75 Ending Dec 11, 2017 milestone Dec 4, 2017
@AparnaKarve AparnaKarve deleted the bz1515710_fix_helper_method_access branch December 4, 2017 21:10
simaishi pushed a commit that referenced this pull request Dec 4, 2017
@simaishi
Merge pull request #2923 from AparnaKarve/bz1515710_fix_helper_method…
1a44e62 
…_access

Fix `ProvisionCustomizeHelper` helper method access in VM controllers
(cherry picked from commit 3f552a2)

https://bugzilla.redhat.com/show_bug.cgi?id=1520672
@simaishi
Copy link
Contributor

simaishi commented Dec 4, 2017

Gaprindashvili backport details:

$ git log -1
commit 1a44e623481324c63d7dce3f16ea64e90494c015
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Mon Dec 4 12:54:53 2017 -0800

    Merge pull request #2923 from AparnaKarve/bz1515710_fix_helper_method_access
    
    Fix `ProvisionCustomizeHelper` helper method access in VM controllers
    (cherry picked from commit 3f552a2aae4dfa621da6af67cb7dacdea65fd4eb)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1520672

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dclarizio dclarizio

Labels
blocker bug compute/infrastructure gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AparnaKarve @miq-bot @lfu @simaishi @dclarizio