Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check_box_tag parameters for snap_memory #217

Merged
merged 1 commit into from
Jan 23, 2017

Conversation

agrare
Copy link
Member

@agrare agrare commented Jan 23, 2017

The checkbox for :snap_memory was incorrectly setting the value leading to it being interpreted as always false.

Before:

params[:snap_memory]
"{:value=>\"1\", :checked=>false}"

After:

params[:snap_memory]
"1"

This value is being compared to "1" here so we were never creating a VM snapshot with memory.

https://bugzilla.redhat.com/show_bug.cgi?id=1413678

@miq-bot
Copy link
Member

miq-bot commented Jan 23, 2017

Checked commit agrare@429ff99 with ruby 2.2.6, rubocop 0.46.0, and haml-lint 0.19.0
1 file checked, 0 offenses detected
Everything looks good. 👍

@mzazrivec mzazrivec self-assigned this Jan 23, 2017
@mzazrivec mzazrivec added this to the Sprint 53 Ending Jan 30, 2017 milestone Jan 23, 2017
@mzazrivec mzazrivec merged commit 21904d0 into ManageIQ:master Jan 23, 2017
@agrare agrare deleted the fix-snap-memory-checkbox branch January 23, 2017 17:52
@simaishi
Copy link
Contributor

Euwe backport (to manageiq repo) details:

$ git log -1
commit 379fc897d60aa978b959795dbfbfbf523e26caeb
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Mon Jan 23 18:49:14 2017 +0100

    Merge pull request #217 from agrare/fix-snap-memory-checkbox
    
    Fix check_box_tag parameters for snap_memory
    (cherry picked from commit 21904d0319850d110aa01e8d3a0a63d45b9ab2bb)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1416092

@agrare
Copy link
Member Author

agrare commented Feb 24, 2017

@miq-bot add-label darga/yes

@agrare
Copy link
Member Author

agrare commented Feb 24, 2017

@simaishi
Copy link
Contributor

simaishi commented Feb 24, 2017

Darga backport (to manageiq repo) details:

$ git log -1
commit b15926d3379c0394034982a781c5c31709a207f6
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Mon Jan 23 18:49:14 2017 +0100

    Merge pull request #217 from agrare/fix-snap-memory-checkbox
    
    Fix check_box_tag parameters for snap_memory
    (cherry picked from commit 21904d0319850d110aa01e8d3a0a63d45b9ab2bb)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1426655

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants