Generate a new ansible rabbitmq password #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fryguy
reviewed
Oct 12, 2018
| end | ||
|
|
||
| def up | ||
| auth = Authentication.find_by( |
There was a problem hiding this comment.
Will there by multiple of these in the global, or do we not care? Should we do .in_my_region?
There was a problem hiding this comment.
Well it shouldn't matter but we don't want these to get out of sync so I'll do the .in_my_region.
There was a problem hiding this comment.
It's not like the new password is deterministic so it would be particularly bad in this case
|
LGTM |
carbonin
force-pushed
the
generate_new_ansible_rabbit_password
branch
from
3743696
to
10f6739
Compare
bdunne
approved these changes
Oct 12, 2018
|
Damn didn't realize |
carbonin
force-pushed
the
generate_new_ansible_rabbit_password
branch
from
10f6739
to
be0e123
Compare
If the current rabbitmq password contains special characters it will fail a new preflight check in the setup playbook. This is fixed for new installations by ManageIQ/manageiq#18092 but because we re-run the setup playbook when we upgrade the tower version, we also need to correct existing ones. https://bugzilla.redhat.com/show_bug.cgi?id=1638009
carbonin
force-pushed
the
generate_new_ansible_rabbit_password
branch
from
be0e123
to
ec81406
Compare
|
Checked commit carbonin@ec81406 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
👍 |
simaishi
pushed a commit
that referenced
this pull request
Oct 15, 2018
…sword Generate a new ansible rabbitmq password (cherry picked from commit af11356) https://bugzilla.redhat.com/show_bug.cgi?id=1638009
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the current rabbitmq password contains special characters it
will fail a new preflight check in the setup playbook.
This is fixed for new installations by
ManageIQ/manageiq#18092 but because we
re-run the setup playbook when we upgrade the tower version, we
also need to correct existing ones.
https://bugzilla.redhat.com/show_bug.cgi?id=1638009