Skip to content
This repository has been archived by the owner on Jul 25, 2023. It is now read-only.

Update client to use renamed NetworkDiscovery #63

Merged
merged 1 commit into from
Feb 21, 2018
Merged

Update client to use renamed NetworkDiscovery #63

merged 1 commit into from
Feb 21, 2018

Conversation

jrafanie
Copy link
Member

@gildub gildub mentioned this pull request Feb 15, 2018
Closed
@gildub
Copy link
Contributor

gildub commented Feb 15, 2018

@jrafanie, the require line needs to be updated too per now closed #64. Thanks

@gildub gildub mentioned this pull request Feb 15, 2018
Closed
14 tasks
gildub
gildub reviewed Feb 15, 2018
View reviewed changes
Copy link
Contributor

@gildub gildub left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops

gildub
gildub suggested changes Feb 15, 2018
View reviewed changes
Copy link
Contributor

@gildub gildub left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires update - (Just tried to add weight but not much effect since I don't have write access)

@jrafanie jrafanie force-pushed the rename_manageiq_network_to_network_discovery branch from a8b1d63 to dcc2fe1 Compare February 20, 2018 15:29
@miq-bot
Copy link
Member

miq-bot commented Feb 20, 2018

Checked commit jrafanie@dcc2fe1 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@gildub
Copy link
Contributor

gildub commented Feb 21, 2018

@bdunne, please review.

@agrare agrare self-assigned this Feb 21, 2018
@agrare agrare merged commit ccaeafa into ManageIQ:master Feb 21, 2018
@agrare agrare added this to the Sprint 80 Ending Feb 26, 2018 milestone Feb 21, 2018
@gildub
Copy link
Contributor

gildub commented Mar 8, 2018

@miq-bot add_label gaprindashvili/yes

simaishi pushed a commit that referenced this pull request Mar 8, 2018
@agrare @simaishi
Merge pull request #63 from jrafanie/rename_manageiq_network_to_netwo…
d2d9129 
…rk_discovery

Update client to use renamed NetworkDiscovery
(cherry picked from commit ccaeafa)

https://bugzilla.redhat.com/show_bug.cgi?id=1552665
@simaishi
Copy link
Contributor

simaishi commented Mar 8, 2018

Gaprindashvili backport details:

$ git log -1
commit d2d9129f53260e89eda392f8b5ec69c28802ca7e
Author: Adam Grare <agrare@redhat.com>
Date:   Wed Feb 21 09:30:28 2018 -0500

    Merge pull request #63 from jrafanie/rename_manageiq_network_to_network_discovery
    
    Update client to use renamed NetworkDiscovery
    (cherry picked from commit ccaeafadf68fcdb5275a2d88d8c3d86a628fd0db)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1552665

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gildub gildub gildub requested changes

Assignees

@agrare agrare

Labels
gaprindashvili/backported refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jrafanie @gildub @miq-bot @simaishi @agrare