Add 'default_security_group' method to CloudTenant

app/models/manageiq/providers/openstack/cloud_manager/cloud_tenant.rb

@@ -49,6 +49,14 @@ def self.display_name(number = 1)
     n_('Cloud Tenant (OpenStack)', 'Cloud Tenants (OpenStack)', number)
   end
 
+  def default_security_group
+    default = security_groups.find_by(:name => "default")
+    return default if default
+    # if there's not a security group named "default",
+    # then return the security group with the most VMs in it.
+    security_groups.sort { |sg| sg.vms.count }.last
+  end
+
   private
 
   def connection_options

spec/models/manageiq/providers/openstack/cloud_manager/cloud_tenant_spec.rb

@@ -0,0 +1,69 @@
+describe ManageIQ::Providers::Openstack::CloudManager::CloudTenant do
+  let(:ems) { FactoryGirl.create(:ems_openstack) }
+  let(:tenant) { FactoryGirl.create(:cloud_tenant_openstack, :ext_management_system => ems) }
+
+  describe 'tenant methods' do
+    context ".default_security_group" do
+      it 'returns the security group named "default" if it exists' do
+        test01 = FactoryGirl.create(:security_group_openstack,
+                                    :name         => 'test_1',
+                                    :ems_ref      => 'one_id',
+                                    :cloud_tenant => tenant)
+        test02 = FactoryGirl.create(:security_group_openstack,
+                                    :name         => 'test_2',
+                                    :ems_ref      => 'two_id',
+                                    :cloud_tenant => tenant)
+        default = FactoryGirl.create(:security_group_openstack,
+                                     :name         => 'default',
+                                     :ems_ref      => 'default_id',
+                                     :cloud_tenant => tenant)
+        # Go through the convoluted effort of assigning a VM to
+        # one of the security groups.
+        # The 'default' security group should be returned
+        # despite not having the most vms
+        vm = FactoryGirl.create(:vm_openstack)
+        network_port = FactoryGirl.create(:network_port_openstack)
+        network_port.device = vm
+        network_port.save
+        network_port_security_group = NetworkPortSecurityGroup.new
+        network_port_security_group.network_port_id = network_port.id
+        network_port_security_group.security_group_id = test02.id
+        network_port_security_group.save
+
+        expect(tenant.default_security_group).to eq default
+      end
+
+      it 'returns the most populated security group if there is no default' do
+        test01 = FactoryGirl.create(:security_group_openstack,
+                                    :name         => 'test_1',
+                                    :ems_ref      => 'one_id',
+                                    :cloud_tenant => tenant)
+        test02 = FactoryGirl.create(:security_group_openstack,
+                                    :name         => 'test_2',
+                                    :ems_ref      => 'two_id',
+                                    :cloud_tenant => tenant)
+        test03 = FactoryGirl.create(:security_group_openstack,
+                                    :name         => 'test_3',
+                                    :ems_ref      => 'three_id',
+                                    :cloud_tenant => tenant)
+        # Go through the convoluted effort of assigning a VM to
+        # one of the security groups.
+        # The security group with the VM is the one that should be returned
+        vm = FactoryGirl.create(:vm_openstack)
+        network_port = FactoryGirl.create(:network_port_openstack)
+        network_port.device = vm
+        network_port.save
+        network_port_security_group = NetworkPortSecurityGroup.new
+        network_port_security_group.network_port_id = network_port.id
+        network_port_security_group.security_group_id = test02.id
+        network_port_security_group.save
+
+        expect(tenant.default_security_group).to eq test02
+      end
+
+      it 'returns nil if there are no security groups' do
+        expect(tenant.default_security_group).to eq nil
+      end
+    end
+  end
+end