Enable check metadata not deleted specs #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ladas
force-pushed
the
enable_check_metadata_not_deleted_specs
branch
from
94b0e29
to
18c9970
Compare
|
@cben this and the dependencies will make the specs pass again. There was a missing dependency in this edge case, that is why it didn't disconnect via parent, but it destroyed it. |
cben
reviewed
Aug 30, 2017
| @@ -557,7 +555,7 @@ def assert_container_node_with_no_hawk_attributes | |||
| end | |||
|
|
|||
| # TODO: pending proper graph store_unused_images implemetation | |||
| include_examples "openshift refresher VCR tests", :check_metadata_not_deleted => false | |||
| include_examples "openshift refresher VCR tests" | |||
There was a problem hiding this comment.
drop above TODO line too, it was explaining the check_metadata_not_deleted (same below)
There was a problem hiding this comment.
hum, will do, a bad rebase it seems
24 tasks
Change to a new initialize_custom_attributes_collections format
Enable check_metadata_not_deleted specs
Change to a newer initialize_custom_attributes_collections format
Ladas
force-pushed
the
enable_check_metadata_not_deleted_specs
branch
from
18c9970
to
cd1a005
Compare
|
Checked commits Ladas/manageiq-providers-openshift@37ec59b~...cd1a005 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@cben can you review/approve this? |
cben
approved these changes
Oct 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
Enable check metadata not deleted specs.