WIP: Initial PR for using the provisioning state machine

[rodneyhbrown7]

The purpose of this PR is to implement the provisioning state machine recently added to the manage IQ core in :
ManageIQ/manageiq#18573

Provisioning will include the following steps (to be extended in future MRs):

• update firmware
• update configuration

Developing in support of RFE: https://bugzilla.redhat.com/show_bug.cgi?id=1649528

[miq-bot]

Some comments on commits rodneyhbrown7/manageiq-providers-lenovo@f8b195e~...e2a17e7

app/models/manageiq/providers/lenovo/physical_infra_manager/physical_server/provisioning.rb

• ⚠️ - 16 - Detected puts. Remove all debugging statements.
• ⚠️ - 7 - Detected puts. Remove all debugging statements.

spec/models/manageiq/providers/lenovo/physical_infra_manager/provision/state_machine.rb

• ⚠️ - 28 - Detected puts. Remove all debugging statements.

[miq-bot]

Checked commits rodneyhbrown7/manageiq-providers-lenovo@f8b195e~...e2a17e7 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
8 files checked, 72 offenses detected

app/models/manageiq/providers/lenovo/physical_infra_manager/physical_server.rb

• ❗ - Line 12, Col 5 - Layout/Tab - Tab detected.
• ❗ - Line 12, Col 6 - Layout/CommentIndentation - Incorrect indentation detected (column 5 instead of 6).
• ❗ - Line 12, Col 6 - Layout/LeadingCommentSpace - Missing space after #.
• ❗ - Line 13, Col 7 - Style/RedundantReturn - Redundant return detected.

app/models/manageiq/providers/lenovo/physical_infra_manager/physical_server/provisioning.rb

• ❗ - Line 12, Col 9 - Layout/LeadingCommentSpace - Missing space after #.
• ❗ - Line 15, Col 7 - Layout/LeadingCommentSpace - Missing space after #.
• ❗ - Line 16, Col 7 - Rails/Output - Do not write to stdout. Use Rails's logger if you want to log.
• ❗ - Line 22, Col 7 - Layout/LeadingCommentSpace - Missing space after #.
• ❗ - Line 23, Col 11 - Layout/TrailingWhitespace - Trailing whitespace detected.
• ❗ - Line 25, Col 1 - Layout/EmptyLinesAroundModuleBody - Extra empty line detected at module body end.
• ❗ - Line 7, Col 7 - Rails/Output - Do not write to stdout. Use Rails's logger if you want to log.

spec/models/manageiq/providers/lenovo/physical_infra_manager/physical_server/provisioning2_spec.rb

• ❗ - Line 1, Col 1 - Layout/EndOfLine - Carriage return character detected.
• ❗ - Line 21, Col 1 - Layout/TrailingWhitespace - Trailing whitespace detected.
• ❗ - Line 27, Col 33 - Style/MethodCallWithoutArgsParentheses - Do not use parentheses for method calls with no arguments.
• ❗ - Line 31, Col 1 - Layout/TrailingWhitespace - Trailing whitespace detected.

spec/models/manageiq/providers/lenovo/physical_infra_manager/physical_server/provisioning_spec.rb

• ❗ - Line 1, Col 1 - Layout/EndOfLine - Carriage return character detected.
• ❗ - Line 40, Col 3 - Layout/CommentIndentation - Incorrect indentation detected (column 2 instead of 4).
• ❗ - Line 46, Col 9 - Layout/LeadingCommentSpace - Missing space after #.
• ❗ - Line 47, Col 9 - Layout/LeadingCommentSpace - Missing space after #.
• ❗ - Line 52, Col 5 - Layout/LeadingCommentSpace - Missing space after #.
• ❗ - Line 57, Col 5 - Layout/LeadingCommentSpace - Missing space after #.
• ❗ - Line 62, Col 7 - Layout/LeadingCommentSpace - Missing space after #.
• ❗ - Line 66, Col 5 - Layout/LeadingCommentSpace - Missing space after #.
• ❗ - Line 69, Col 5 - Layout/LeadingCommentSpace - Missing space after #.

spec/models/manageiq/providers/lenovo/physical_infra_manager/physical_server_spec.rb

• ❗ - Line 22, Col 7 - Layout/LeadingCommentSpace - Missing space after #.
• ❗ - Line 28, Col 7 - Layout/LeadingCommentSpace - Missing space after #.
• ❗ - Line 29, Col 39 - Style/BracesAroundHashParameters - Redundant curly braces around a hash parameter.
• ❗ - Line 29, Col 45 - Layout/SpaceAroundOperators - Surrounding space missing for operator =>.
• ❗ - Line 29, Col 68 - Layout/SpaceAroundOperators - Surrounding space missing for operator =>.
• ❗ - Line 37, Col 49 - Layout/SpaceAroundBlockParameters - Space before first block parameter detected.
• ❗ - Line 42, Col 1 - Layout/TrailingWhitespace - Trailing whitespace detected.

spec/models/manageiq/providers/lenovo/physical_infra_manager/provision/state_machine.rb

• ❗ - Line 13, Col 1 - Layout/TrailingWhitespace - Trailing whitespace detected.
• ❗ - Line 14, Col 110 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 14, Col 121 - Layout/SpaceAroundOperators - Operator => should be surrounded by a single space.
• ❗ - Line 14, Col 19 - Style/BlockDelimiters - Avoid using {...} for multi-line blocks.
• ❗ - Line 14, Col 21 - Layout/MultilineBlockLayout - Block body expression is on the same line as the block start.
• ❗ - Line 14, Col 62 - Layout/SpaceAfterComma - Space missing after comma.
• ❗ - Line 14, Col 85 - Layout/SpaceAroundOperators - Surrounding space missing for operator =>.
• ❗ - Line 15, Col 113 - Layout/BlockEndNewline - Expression at 15, 113 should be on its own line.
• ❗ - Line 23, Col 22 - Rails/SkipsModelValidations - Avoid using update_attribute because it skips validations.
• ❗ - Line 24, Col 12 - Style/BlockDelimiters - Avoid using {...} for multi-line blocks.
• ❗ - Line 24, Col 14 - Layout/MultilineBlockLayout - Block body expression is on the same line as the block start.
• ❗ - Line 24, Col 57 - Layout/TrailingWhitespace - Trailing whitespace detected.
• ❗ - Line 25, Col 35 - Layout/BlockEndNewline - Expression at 25, 35 should be on its own line.
• ❗ - Line 25, Col 37 - Layout/BlockEndNewline - Expression at 25, 37 should be on its own line.
• ❗ - Line 32, Col 38 - Layout/SpaceInsideParens - Space inside parentheses detected.
• ❗ - Line 32, Col 39 - Style/BracesAroundHashParameters - Redundant curly braces around a hash parameter.
• ❗ - Line 32, Col 46 - Layout/SpaceAroundOperators - Surrounding space missing for operator =>.
• ❗ - Line 32, Col 70 - Layout/SpaceAroundOperators - Surrounding space missing for operator =>.
• ❗ - Line 48, Col 3 - Layout/CommentIndentation - Incorrect indentation detected (column 2 instead of 4).
• ❗ - Line 53, Col 9 - Layout/LeadingCommentSpace - Missing space after #.
• ❗ - Line 56, Col 9 - Layout/LeadingCommentSpace - Missing space after #.
• ❗ - Line 58, Col 9 - Layout/LeadingCommentSpace - Missing space after #.
• ❗ - Line 59, Col 9 - Layout/LeadingCommentSpace - Missing space after #.
• ❗ - Line 5, Col 38 - Layout/SpaceAfterComma - Space missing after comma.
• ❗ - Line 5, Col 46 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 5, Col 49 - Layout/SpaceAroundOperators - Operator => should be surrounded by a single space.
• ❗ - Line 5, Col 59 - Layout/SpaceAfterComma - Space missing after comma.
• ❗ - Line 5, Col 83 - Layout/SpaceAfterComma - Space missing after comma.
• ❗ - Line 60, Col 9 - Layout/LeadingCommentSpace - Missing space after #.
• ❗ - Line 61, Col 9 - Layout/LeadingCommentSpace - Missing space after #.
• ❗ - Line 63, Col 9 - Layout/LeadingCommentSpace - Missing space after #.
• ❗ - Line 72, Col 2 - Layout/CommentIndentation - Incorrect indentation detected (column 1 instead of 0).
• ❗ - Line 77, Col 1 - Layout/CommentIndentation - Incorrect indentation detected (column 0 instead of 4).
• ❗ - Line 80, Col 1 - Layout/TrailingBlankLines - 1 trailing blank lines detected.
• ❗ - Line 9, Col 105 - Layout/SpaceAroundOperators - Operator => should be surrounded by a single space.
• ❗ - Line 9, Col 48 - Layout/SpaceAfterComma - Space missing after comma.
• ❗ - Line 9, Col 64 - Layout/SpaceAfterComma - Space missing after comma.
• ❗ - Line 9, Col 74 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 9, Col 76 - Layout/SpaceAroundOperators - Operator => should be surrounded by a single space.
• ❗ - Line 9, Col 93 - Layout/SpaceAfterComma - Space missing after comma.
• ❗ - Line 9, Col 99 - Layout/ExtraSpacing - Unnecessary spacing detected.

[miq-bot]

This pull request has been automatically closed because it has not been updated for at least 6 months.

Feel free to reopen this pull request if these changes are still valid.

Thank you for all your contributions!