Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove newlines from help message #539

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Sep 30, 2024

Newlines can cause trouble with translations as well as presentation in the UI. This particular string doesn't actually need the newlines, so this commit changes it to just not have them.

Alternative to ManageIQ/manageiq#23213

@agrare Please review. cc @jrafanie

Newlines can cause trouble with translations as well as presentation in
the UI. This particular string doesn't actually need the newlines, so
this commit changes it to just not have them.

Alternative to ManageIQ/manageiq#23213
@Fryguy
Copy link
Member Author

Fryguy commented Sep 30, 2024

@agrare Total aside, but the entirety of the Options class uses N_, which I don't think actually does the translation. N_ is meant for constants where you want to delay the translation until later, but something needs to call _ on it. I think this particular set is meant to be queried over the API and thus translated, so I think these are all wrong, or am I missing some detail here?

@agrare
Copy link
Member

agrare commented Sep 30, 2024

@Fryguy any of the params_for_create/params_for_update methods are all OPTIONS calls over the API so I'm not sure if the locale is set in that context. I'm having trouble finding where those Options are used maybe it is old code that is no longer needed? Will need more investigation.

@agrare agrare merged commit 182421a into ManageIQ:master Sep 30, 2024
4 checks passed
@Fryguy Fryguy deleted the better_help_message branch October 1, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants