Use base classes for Inventory, Collector, Persistor and Parser #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use base classes for Inventory, Collector, Persistor and Parser and making changes to pass CI.
Inventory::Parser helper methods
Fix rubocop issues
|
Checked commits Ladas/manageiq-providers-amazon@80c25ba~...1c2c031 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
durandom
approved these changes
Feb 17, 2017
|
👍 👏 🎉 great to see so much great progress |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use base classes for Inventory, Collector, Persistor and Parser
and making changes to pass CI.
Depends on ManageIQ/manageiq#13907