Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stdin option to shell_exec #382

Merged
merged 1 commit into from
Oct 10, 2018
Merged

Add stdin option to shell_exec #382

merged 1 commit into from
Oct 10, 2018

Conversation

ghost
Copy link

@ghost ghost commented Oct 10, 2018 •
edited by ghost
Loading

This PR is a follow up of #379 that adds support for stdin to shell_exec method, as exec and su_exec are mostly hidden by shell_exec. This is also used in ManageIQ/manageiq#18064/: app/models/conversion_host.rb:42.

Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1634029

@ghost
Copy link
Author

ghost commented Oct 10, 2018

@miq-bot add-reviewer carbonin

@miq-bot miq-bot requested a review from carbonin October 10, 2018 10:28
@carbonin carbonin self-assigned this Oct 10, 2018
@carbonin carbonin merged commit 4442396 into ManageIQ:master Oct 10, 2018
@carbonin carbonin added this to the Sprint 97 Ending Oct 22, 2018 milestone Oct 10, 2018
@ghost ghost mentioned this pull request Oct 10, 2018
Merged
@ghost ghost deleted the add_stdin_to_shell_exec branch October 10, 2018 15:23
simaishi pushed a commit that referenced this pull request Oct 11, 2018
@carbonin @simaishi
Merge pull request #382 from fdupont-redhat/add_stdin_to_shell_exec
1ee45ac 
Add stdin option to shell_exec

(cherry picked from commit 4442396)

https://bugzilla.redhat.com/show_bug.cgi?id=1634029
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit 1ee45ac9278b5b758bbce9271136f80c597532b4
Author: Nick Carboni <ncarboni@redhat.com>
Date:   Wed Oct 10 09:41:47 2018 -0400

    Merge pull request #382 from fdupont-redhat/add_stdin_to_shell_exec
    
    Add stdin option to shell_exec
    
    (cherry picked from commit 4442396b4f7271f1402a78b2164da450f4b4e6cd)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1634029

@kbrock
Copy link
Member

kbrock commented Oct 12, 2018

nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@carbonin carbonin

Labels
enhancement hammer/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simaishi @kbrock @carbonin @fabiendupont