Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix require net/sftp for Users SSA #323

Merged
merged 1 commit into from
Jan 5, 2018
Merged

Fix require net/sftp for Users SSA #323

merged 1 commit into from
Jan 5, 2018

Conversation

aufi
Copy link
Member

@aufi aufi commented Jan 5, 2018

Fixing bug when users synchronization failed during SSA because of failure
in MiqSshUtil caused by uninitialized constant Net::SFTP.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1529127

@aufi
Fix require net/sftp for Users SSA
1a14908 
Fixing bug when users synchronization failed during SSA because of failure
in MiqSshUtil caused by uninitialized constant Net::SFTP.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1529127
@aufi
Copy link
Member Author

aufi commented Jan 5, 2018

@miq-bot add_label bug,blocker,gapridanshvili/yes

@miq-bot
Copy link
Member

miq-bot commented Jan 5, 2018

@aufi Cannot apply the following label because they are not recognized: gapridanshvili/yes

@aufi
Copy link
Member Author

aufi commented Jan 5, 2018 •
edited
Loading

@miq-bot add_label gaprindashvili/yes

@miq-bot
Copy link
Member

miq-bot commented Jan 5, 2018

Checked commit aufi@1a14908 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@carbonin carbonin self-assigned this Jan 5, 2018
@carbonin carbonin merged commit 55e14e6 into ManageIQ:master Jan 5, 2018
@carbonin carbonin added this to the Sprint 77 Ending Jan 15, 2018 milestone Jan 5, 2018
simaishi pushed a commit that referenced this pull request Jan 5, 2018
@carbonin @simaishi
Merge pull request #323 from aufi/fix_sftp_require_users_ssa
9de8568 
Fix require net/sftp for Users SSA
(cherry picked from commit 55e14e6)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1531606
@simaishi
Copy link
Contributor

simaishi commented Jan 5, 2018

Gaprindashvili backport details:

$ git log -1
commit 9de8568e2726d9989d435e91a04da547d7752de6
Author: Nick Carboni <ncarboni@redhat.com>
Date:   Fri Jan 5 08:45:38 2018 -0500

    Merge pull request #323 from aufi/fix_sftp_require_users_ssa
    
    Fix require net/sftp for Users SSA
    (cherry picked from commit 55e14e61a59983c068c428117f7e742a142ef51e)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1531606

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carbonin carbonin carbonin approved these changes

Assignees

@carbonin carbonin

Labels
blocker bug gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aufi @miq-bot @simaishi @carbonin