Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change refresh target to src_vm_or_dest_host for DrsMigrateVM_Task_Complete #531

Merged
merged 1 commit into from
May 21, 2019

Conversation

lfu
Copy link
Member

@lfu lfu commented May 1, 2019

If the VM was migrated off of the host before refresh adds the VM to the database then the src_vm target for this "/System/event_handlers/event_action_refresh?target=src_vm" won't work.
We need to refresh the dest_host.

Depends on ManageIQ/manageiq#18715.

https://bugzilla.redhat.com/show_bug.cgi?id=1696889

@miq-bot add_label bug, hammer/yes, changelog/yes

…mplete.

If the VM was migrated off of the host before refresh adds the VM to the database then the src_vm target
for this "/System/event_handlers/event_action_refresh?target=src_vm" won't work.
We need to refresh the dest_host.

https://bugzilla.redhat.com/show_bug.cgi?id=1696889
@miq-bot
Copy link
Member

miq-bot commented May 1, 2019

Checked commit lfu@d253dba with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@coveralls
Copy link

coveralls commented May 1, 2019

Pull Request Test Coverage Report for Build 3022

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.909%

Totals Coverage Status
Change from base Build 3010: 0.0%
Covered Lines: 2884
Relevant Lines: 2976

💛 - Coveralls

@tinaafitz
Copy link
Member

@d-m-u Please review.

@Fryguy Fryguy self-assigned this May 21, 2019
@tinaafitz tinaafitz merged commit 23d81c7 into ManageIQ:master May 21, 2019
simaishi pushed a commit that referenced this pull request May 22, 2019
Change refresh target to src_vm_or_dest_host for DrsMigrateVM_Task_Complete

(cherry picked from commit 23d81c7)

https://bugzilla.redhat.com/show_bug.cgi?id=1712595
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit a89dec6296a598abd09ada0b8118c8b4635d2774
Author: tina <tfitzger@redhat.com>
Date:   Tue May 21 13:47:38 2019 -0400

    Merge pull request #531 from lfu/src_vm_or_dest_host_1696889
    
    Change refresh target to src_vm_or_dest_host for DrsMigrateVM_Task_Complete
    
    (cherry picked from commit 23d81c79c915ae145a4e3d68024b1f8bcad51a9c)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1712595

@tinaafitz tinaafitz added this to the Sprint 112 Ending May 27, 2019 milestone May 28, 2019
@lfu lfu deleted the src_vm_or_dest_host_1696889 branch July 26, 2019 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants