V2V - Workaround for network mappings storage #470
Conversation
|
@miq-bot add-label transformation, bug, hammer/yes, blocker |
Pull Request Test Coverage Report for Build 2338
💛 - Coveralls |
| @@ -25,6 +25,7 @@ def populate_factory_config | |||
|
|
|||
| def main | |||
| raise 'Preflight check has failed' unless @task.preflight_check | |||
| @task.set_option(:network_mappings, @task.network_mappings) | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
It's a workaround until I find why it's not set by the call to preflight_check. Without it, migration fails and blocks QE.
@gmcculloug I've added a TODO comment to revisit later. Sorry for the technical debt.
There was a problem hiding this comment.
@fdupont-redhat I need to understand what this really means:
why it's not set by the call to preflight_check`
I suggest we focus on this a little before jumping right to this work-around. We can discuss.
|
Checked commits fabiendupont/manageiq-content@cb4ee09~...7eed3db with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@gmcculloug found the solution to preflight_check not setting the network mappings: it was not saved in the DB. Another PR fixes the issue: ManageIQ/manageiq#18194, so this one can be closed. |
ghost
closed this
When migrating a VM to OpenStack, we need the IP addresses of the source virutal machine to create the associated network ports. This PR add a statement to store the network mappings, which contain the IP addresses if VMware tools are running, into the task options hash for later consumption.
Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1649020