Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[RFR]Automate: test_service_provision_retire_from_global_region_generic #10317

Merged
merged 1 commit into from
Sep 11, 2020

Conversation

valaparthvi
Copy link
Contributor

@valaparthvi valaparthvi commented Sep 7, 2020

Purpose or Intent

  • Adding tests
    1. test_service_provision_retire_from_global_region_generic
  • Enhancement
    1. Implement retire service for REST API.

PRT Run

{{ pytest: cfme/tests/services/test_service_catalogs_multi_region.py::test_service_provision_retire_from_global_region_generic --long-running -vvv }}

@valaparthvi valaparthvi added enhancement test-automation To be applied on PR's which are automating existing manual cases labels Sep 7, 2020
@valaparthvi valaparthvi changed the title Automate: test_service_provision_retire_from_global_region_generic [WIPTEST]Automate: test_service_provision_retire_from_global_region_generic Sep 7, 2020
@dajoRH
Copy link
Contributor

dajoRH commented Sep 7, 2020

I detected some fixture changes in commit 627b056

The local fixture remote_generic_catalog_item is used in the following files:

  • cfme/tests/services/test_service_catalogs_multi_region.py

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

@valaparthvi valaparthvi changed the title [WIPTEST]Automate: test_service_provision_retire_from_global_region_generic [RFR]Automate: test_service_provision_retire_from_global_region_generic Sep 7, 2020
@@ -269,19 +292,9 @@ def _clear_request_service():
assert service.exists

# Retire the service via UI or REST, depending on context
if context == ViaUI:
with appliance.context.use(context):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@mshriver mshriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving functionality into the appropriate contexts for sentaku!

@mshriver mshriver merged commit 686bbb0 into ManageIQ:master Sep 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement test-automation To be applied on PR's which are automating existing manual cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants