Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[RFR] 5.10 Fix find_request to loop over static list of dict keys #10309

Merged
merged 1 commit into from
Aug 31, 2020
Merged

[RFR] 5.10 Fix find_request to loop over static list of dict keys #10309

merged 1 commit into from
Aug 31, 2020

Conversation

tpapaioa
Copy link
Contributor

This PR backports a fix from master to 5.10-breakpoint-patched, so that RequestsView.find_request() loops over a static list of dictionary keys instead of the dynamic view returned by dict.keys() in Python 3. This fixes exceptions like the following:

>       for key in cells.keys():
E       RuntimeError: dictionary keys changed during iteration

cfme/services/requests.py:302: RuntimeError (cfme/fixtures/log.py:83)

@tpapaioa tpapaioa changed the title [WIPTEST] Fix find_request to loop over static list of dict keys [RFR] 5.10 Fix find_request to loop over static list of dict keys Aug 24, 2020
@mshriver mshriver merged commit f4b727a into ManageIQ:5.10-breakpoint-patched Aug 31, 2020
@tpapaioa tpapaioa deleted the fix_find_request_5.10 branch August 31, 2020 16:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mshriver mshriver mshriver approved these changes

Assignees
No one assigned
Labels
fix-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tpapaioa @mshriver