Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Automating upload/remove image on catalog bundle test #10290

Merged
merged 1 commit into from
Aug 12, 2020

Conversation

niyazRedhat
Copy link
Contributor

Purpose or Intent

PRT Run

{{pytest: cfme/tests/services/test_catalog_item.py::test_upload_delete_custom_image_on_bundle --long-running -svvvv }}

@niyazRedhat niyazRedhat force-pushed the bunlde-t branch 2 times, most recently from afa1880 to 9a67456 Compare August 11, 2020 14:37
@niyazRedhat niyazRedhat changed the title [WIPTEST] Automating upload/remove image on catalog bundle test [RFR] Automating upload/remove image on catalog bundle test Aug 12, 2020
Copy link
Contributor

@valaparthvi valaparthvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 suggestions, else LGTM.

cfme/services/catalogs/catalog_items/__init__.py Outdated Show resolved Hide resolved
cfme/tests/services/test_catalog_item.py Outdated Show resolved Hide resolved
@valaparthvi valaparthvi added the test-automation To be applied on PR's which are automating existing manual cases label Aug 12, 2020
@valaparthvi valaparthvi changed the title [RFR] Automating upload/remove image on catalog bundle test [1LP][RFR] Automating upload/remove image on catalog bundle test Aug 12, 2020
Copy link
Contributor

@digitronik digitronik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Just two questions

cfme/tests/services/test_catalog_item.py Outdated Show resolved Hide resolved
Copy link
Contributor

@digitronik digitronik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @niyazRedhat
LGTM

@digitronik digitronik merged commit 28b0d2a into ManageIQ:master Aug 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
test-automation To be applied on PR's which are automating existing manual cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants