This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[NOTEST][RFR] adding BZ coverage and cleanup tcs #10248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-dupuy
reviewed
Jul 9, 2020
dgaikwad
force-pushed
the
adding_coverage
branch
from
6ee7756
to
f0c9472
Compare
dgaikwad
changed the title
mshriver
reviewed
Jul 10, 2020
mshriver
changed the title
dgaikwad
force-pushed
the
adding_coverage
branch
from
f0c9472
to
e305e78
Compare
dgaikwad
changed the title
dgaikwad
changed the title
mshriver
changed the title
dgaikwad
force-pushed
the
adding_coverage
branch
from
e305e78
to
7be6a7f
Compare
mshriver
changed the title
mshriver
reviewed
Jul 13, 2020
| @pytest.mark.manual | ||
| @pytest.mark.tier(1) | ||
| @pytest.mark.meta(coverage=[1854839]) | ||
| def test_chargeback_report(): |
There was a problem hiding this comment.
Why place this with the external auth test cases, when there's no external authentication involved in the test?
I think this test also belongs in test_access_control module with the other test, or in cfme/tests/intelligence/test_chargeback_manual.py
dgaikwad
changed the title
dgaikwad
force-pushed
the
adding_coverage
branch
from
7be6a7f
to
cdcb93f
Compare
dgaikwad
force-pushed
the
adding_coverage
branch
from
cdcb93f
to
0ea4deb
Compare
dgaikwad
changed the title
mshriver
approved these changes
Jul 13, 2020
mshriver
changed the title
jawatts
approved these changes
Jul 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or Intent
PRT Run