Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Automate: test_service_select_tenants #10119

Merged
merged 1 commit into from
May 21, 2020

Conversation

valaparthvi
Copy link
Contributor

Purpose or Intent

  • Automate tests
    1. test_service_select_tenants
  • Enhancement
    1. Add widgets for additional_tenants, currency, zone, price_per_month.
    2. Add methods to add 'Additional Tenants`.
    3. Enhance CloudInfraCatalogItem.fill_dict and NonCloudInfraCatalogItem.fill_dict to work when no catalog is provided while creating catalog item.

PRT Run

{{ pytest: cfme/tests/services/test_catalog_item.py -k "test_service_select_tenants" }}

@valaparthvi valaparthvi added the test-automation To be applied on PR's which are automating existing manual cases label May 15, 2020
@dajoRH
Copy link
Contributor

dajoRH commented May 18, 2020

I detected some fixture changes in commit 342c08e

The local fixture tenant is used in the following files:

  • cfme/tests/services/test_catalog_item.py
    • test_service_select_tenants

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

@valaparthvi valaparthvi changed the title [WIPTEST] Automate: test_service_select_tenants [RFR] Automate: test_service_select_tenants May 18, 2020
Copy link
Contributor

@niyazRedhat niyazRedhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks for the PR

Copy link
Contributor

@john-dupuy john-dupuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice PR!

@john-dupuy john-dupuy changed the title [RFR] Automate: test_service_select_tenants [1LP][RFR] Automate: test_service_select_tenants May 19, 2020
@mshriver mshriver merged commit ce564ab into ManageIQ:master May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lint-ok test-automation To be applied on PR's which are automating existing manual cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants