[1LP][RFR] Automate: test_retire_multiple_services

[valaparthvi]

Purpose or Intent

• Adding tests
  1. test_retire_multiple_services
• Enhancement
  1. Add teardown to catalog_item fixture.
  2. enhance services helper function to take a service_template.
  3. Remove unnecessary code from helper functions in gen_data.py.

PRT Run

{{ pytest: cfme/tests/services/test_myservice.py -k "test_retire_multiple_services" --long-running}}

[dajoRH]

I detected some fixture changes in commit 961fa06

Show fixtures

The global fixture catalog_item is used in the following files:

• cfme/tests/ansible/test_embedded_ansible_automate.py
• cfme/tests/automate/custom_button/test_catalog_custom_button.py
• cfme/tests/automate/test_ansible_tower_automate.py
• cfme/tests/automate/test_service_automate.py
• cfme/tests/cloud_infra_common/test_html5_vm_console_ssui.py
• cfme/tests/services/test_dialog_element_in_catalog.py
• cfme/tests/services/test_dialog_regex_validation_in_catalog.py
• cfme/tests/services/test_dynamicdd_dialogelement.py
• cfme/tests/services/test_myservice.py
  • test_service_state
  • services_vms_list
  • test_retire_service_bundle_and_vms
• cfme/tests/services/test_request.py
  • test_copy_request_bz1194479
• cfme/tests/services/test_service_catalogs.py
  • test_order_catalog_item
  • test_order_catalog_bundle
  • test_request_with_orphaned_template
  • test_order_service_after_deleting_provider
• cfme/tests/services/test_service_customer_bz.py
  • test_edit_bundle_entry_point
• cfme/tests/services/test_service_manual_approval.py
• cfme/tests/services/test_service_rbac.py
  • test_service_rbac_catalog_item
  • test_service_rbac_request
• cfme/tests/ssui/test_ssui_myservice.py
• cfme/tests/ssui/test_ssui_service_catalogs.py

The local fixture services_vms_list is used in the following files:

• cfme/tests/services/test_myservice.py
  • test_retire_multiple_services

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

[niyazRedhat]

LGTM

[john-dupuy]

LGTM, thanks @valaparthvi