Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][NOTEST][RFR] Add test coverage for Bugzila #10103

Merged
merged 1 commit into from
May 19, 2020
Merged

[1LP][NOTEST][RFR] Add test coverage for Bugzila #10103

merged 1 commit into from
May 19, 2020

Conversation

Gauravtalreja1
Copy link
Contributor

@Gauravtalreja1 Gauravtalreja1 commented May 8, 2020 •
edited
Loading

@dajoRH dajoRH added lint-ok and removed needs-lint labels May 8, 2020
@Gauravtalreja1 Gauravtalreja1 changed the title [NOTEST][WIPTEST] Add test coverage for Bugzila [NOTEST][RFR] Add test coverage for Bugzila May 8, 2020
@dajoRH dajoRH removed the WIP-testing label May 8, 2020
valaparthvi
valaparthvi suggested changes May 8, 2020
View reviewed changes
Copy link
Contributor

@valaparthvi valaparthvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these tests start in 5.11 and should be ignored for 5.10, put those markers and add startsin in the polarion docstring.

Tests LGTM otherwise.

cfme/tests/ansible/test_embedded_ansible_manual.py Show resolved Hide resolved
cfme/tests/ansible/test_embedded_ansible_manual.py Outdated Show resolved Hide resolved
@john-dupuy john-dupuy added the manual For things concerning manual test definitions label May 12, 2020
@john-dupuy john-dupuy changed the title [NOTEST][RFR] Add test coverage for Bugzila [NOTEST][WIPTEST] Add test coverage for Bugzila May 12, 2020
@john-dupuy
Copy link
Contributor

Moving to WIPTEST based on comments from @tpapaioa and @valaparthvi

@dajoRH dajoRH added needs-lint and removed lint-ok labels May 14, 2020
@dajoRH dajoRH added lint-ok and removed needs-lint labels May 14, 2020
@Gauravtalreja1 Gauravtalreja1 changed the title [NOTEST][WIPTEST] Add test coverage for Bugzila [NOTEST][RFR] Add test coverage for Bugzila May 14, 2020
@Gauravtalreja1 Gauravtalreja1 force-pushed the test_coverage branch 2 times, most recently from 4360e5b to 9246e6d Compare May 15, 2020 13:45
@valaparthvi valaparthvi changed the title [NOTEST][RFR] Add test coverage for Bugzila [1LP][NOTEST][RFR] Add test coverage for Bugzila May 15, 2020
@tpapaioa
Copy link
Contributor

Looks good to me.

digitronik
digitronik approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@digitronik digitronik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@digitronik digitronik merged commit d08af9b into ManageIQ:master May 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tpapaioa tpapaioa tpapaioa left review comments

@valaparthvi valaparthvi valaparthvi approved these changes

@digitronik digitronik digitronik approved these changes

Assignees
No one assigned
Labels
lint-ok manual For things concerning manual test definitions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Gauravtalreja1 @john-dupuy @tpapaioa @valaparthvi @digitronik @dajoRH