Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing blue color scheme to blue #3723

Merged
merged 1 commit into from
Jan 4, 2020
Merged

Conversation

batzen
Copy link
Collaborator

@batzen batzen commented Jan 4, 2020

This PR changes to blue color scheme to a "real" blue.
@punker76 we already chatted about this ;-)

@timunie
Copy link
Collaborator

timunie commented Jan 4, 2020

Hi @batzen ,
I liked the old blue value. I'm with you that blue should be blue but may we keep the old Theme under a new Name? What do you think?

P. S. : If I'm the only one I don't mind this change because I generate my Themes at runtime. I just thought others might want to keep their Theme as well.

Happy coding
Tim

@batzen
Copy link
Collaborator Author

batzen commented Jan 4, 2020

Adding new color variants is very easy.
But the current/old blue matches cyan very, very closely.
image
Left: current/old blue
Right: cyan

@timunie
Copy link
Collaborator

timunie commented Jan 4, 2020

@batzen thank you this ia a really good point. 👍

@punker76 punker76 added this to the 2.0.0 milestone Jan 4, 2020
@punker76 punker76 merged commit 9b5c30c into MahApps:develop Jan 4, 2020
@punker76
Copy link
Member

punker76 commented Jan 4, 2020

@batzen your changes have been merged, thanks for your contribution 👍

punker76 added a commit that referenced this pull request Jan 24, 2020
@batzen batzen deleted the ColorScheme branch February 16, 2020 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants