Allow using the DropDownButton without a dropdown menu #3704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to latest version
Allow using the DropDownButton without a dropdown menu. If it is necessary to use the DropDownButton without a menu under some circumstances and the "Click" event is used, the button will still try to open the empty menu, which can be seen by the user as a thick black line. This change only tries to open the menu if there actually are some items inside.
|
@floele-sp your changes have been merged, thanks for your contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If it is necessary to use the DropDownButton without a menu under some circumstances (which is reasonable, because you can also hide the arrow button already) and only the "Click" event is used, the button will still try to open the empty menu, which can be seen by the user as a thick black line.
This change only tries to open the menu if there actually are some items inside and makes the DropDownButton behave similar to a normal button when clicked.